4 comments

  • NamlchakKhandro 17 minutes ago
    Who is creating a separate PR for each commit on their feature/fix branch?

    sounds like crazy town.

    I just dont understand why someone would operate like this.

    Lets assume you're squash merging your feature branchs to your local main, then you're raising the them as prs.

    why would you do this?

    • steveklabnik 15 minutes ago
      This is standard practice in the "stacked diffs" world: one review, one commit.
    • what 8 minutes ago
      Why would you have more than one commit for a PR? That sounds like crazy town.
    • jsphweid 9 minutes ago
      1 commit == 1 reviewable unit == 1 PR == 1 CL == 1 feature == 1 fix is a perfectly reasonable way of working.

      I used to work at companies where no one squashed their commits and the entire git logs were filled with 80% non-sense like "temp" or "bad" or "working" with the other 20% being coherent changes. What's the point of doing this I ask?

  • jasonlotito 29 minutes ago
    As someone who much prefers Gerrit's UI/UX over GitHub's UI, I was disappointed that this wasn't replicating the UI for GH reviews.
  • esafak 1 hour ago
    Does it use Github's new stacked PR feature?

    Edit: apparently stacked PRs on GH are older than I thought; the readme references a 2024 blog post about it.

  • martythemaniak 1 hour ago
    Gerrit. Now that's a name I've not heard in a long time. A long time