15 comments

  • amelius 3 minutes ago
    When my system starts using swap space, I've already given up all hopes of a decently running system, so IMHO this particular "bug" doesn't matter much.
  • nasretdinov 1 hour ago
    Unfortunately that's somewhat expected - regardless of implementation, the sole fact that the GC needs to somehow walk the entire tree to trace still referenced sections makes swap highly impractical -- even if you had not had 40ms stop-the-world pauses the LRU cache used by swap would get thrown away at every GC.

    I believe that's actually the same reason why Apple stopped using GC in their frameworks in favour of automatic reference counting.

    • renox 34 minutes ago
      > Unfortunately that's somewhat expected - regardless of implementation

      Yes, that's expected and no not "regardless of implementation": the GC implementation CAN be improved.

      See this discussion on reddit: https://old.reddit.com/r/programming/comments/1wf2fei/40ms_g...

      Copy/pasted here: >>

      I remember a research paper about swap and GC, where the GC cooperated with the OS to avoid this kind of issue. AFAIK it went nowhere, too bad.

      [–]andreiross[S] 15 points il y a 21 jours

      Are you talking about this one? https://cse.buffalo.edu/\~mhertz/bc-pldi-2005.pdf. If so, yes. Too bad. I don't know the repercusions this paper had in the past, though, in the sense of pros and cons of the bookmark collector. Don't know if anyone tried to actually implement it or design it at some point.

      [–]renozyx 9 points il y a 21 jours

      Yes, congratulations for finding it. And I don't know either,. Except that they did implement it on Linux (of course) https://plasma.cs.umass.edu/emery/cooperative-memory-managem...

      <<

    • the8472 4 minutes ago
      [delayed]
    • pjmlp 1 hour ago
      Reference counting is a GC algorithm, and no this isn't expected, it depends pretty much on the implementation.

      Many make the mistake to think there is only one way to do a GC.

      One of the authoritative books on the subject, https://gchandbook.org/contents.html

      And a quite well known paper on the matter as well, https://dl.acm.org/doi/10.1145/1035292.1028982

      • red75prime 13 minutes ago
        You just need to remember that garbage (unreachable reference cycles) isn't collected.
      • IshKebab 23 minutes ago
        In common use, GC refers to mark and sweep and similar systems where allocations are not freed at an easy to predict time.
        • pjmlp 10 minutes ago
          In common use, by those that never learn the theory behind their tools.

          That is a tracing GC by the way.

          There are also tracing GC implementations with deterministic resource management APIs, .NET and D have them for example.

  • jacobgold 2 hours ago
    "It hurts when I do this"

    "Stop doing that"

    If you care about latency, disable swap. System wide or for the specific the cgroup.

    • delamon 2 hours ago
      This is not entirely correct. If you care about latency, then it doesn't matter on which major fault your application gets paused. Disabling swap protects you from data pages being evicted, but code pages can still be paged out.

      If you care about latency, mlock() your memory, do not disable swap. Swap is good and gives the kernel an equal opportunity to evict data and code pages.

      • xxs 1 hour ago
        For GC enabled languages swap is universally bad. Some gc-pauses are indistinguishable from a system crash. It's a side effect on not having tightly specified memory limits.

        I'd rather have applications be oom_killed than having them swap out, the former is rather obvious and demands action.

        • delamon 1 hour ago
          If you want you application to stay in memory, then make it explicitly with mlock()/mlockall().

          Disabling swap will just moves pressere elsewhere: to code pages. And evicted code page is no better: full stall while kernel loads that page from disk.

          • xaduha 31 minutes ago
            I think discussing it in a vacuum is pointless, it should depend on how much memory you have. You can have a swap on, but with a low `vm.swappiness` number.
          • yvdriess 41 minutes ago
            Disabling swap disables loading a process' binary to memory? Or do you mean that evicted code pages will need to get loaded from disk every time.
            • dwattttt 3 minutes ago
              There are good sibling replies answering your question, but to give a specific example: if your application writes something but then doesn't need it anymore. Since we're talking about go, perhaps a data structure you need also holds a reference to data you don't need.

              When the kernel needs memory, it goes hunting for a page it can discard. But since that's transparent, the kernel can only discard a page if it knows it can get it back (after all, it's still got valid data on it, and maybe you'll try access it again later).

              If there's swap, a page full of stale/unneeded data can be written out to swap. But if there's no swap, your page of "dangling data that you'll never use, but is still valid & referenced" can't be discarded; the kernel doesn't know you won't want it later, and it can't recreate the page if it throws it away.

              So like sibling said, at that point it has to find other pages it can evict from memory, ones that _do_ have somewhere persistent they can be written out to. Pages loaded from binaries on disk satisfy that, so those will get dropped instead.

            • delamon 23 minutes ago
              There are two types of pages: anonymous and mapped from files. The code pages are mapped from a binary; they are not very special.

              Under memory pressure, the kernel evicts less popular pages from memory. If a page has been mapped from a file, it is dropped (if dirty, then it is written out first). If it is needed later, the kernel can read it back from the file. If a page is anonymous (read: heap page), then there is no backing file and the kernel copies it to swap before dropping it. This is swapping.

              So, what happens if you disable swap and the kernel is low on memory? What can it evict? Anonymous pages cannot be evicted: there is no swap to put a copy in. The only choice the kernel has is to evict pages that are mapped from files. Those include pages mapped from the executable. You don't eliminate stalls by disabling swap, you just move them elsewhere: the kernel will page out code and your app gets paused whenever the execution flow hits such a page.

            • MobiusHorizons 23 minutes ago
              Under memory pressure the system will free the ram used for code pages because it can always load them back from the executable on disk. It’s the same virtual memory mechanism as swap but without needing dedicated swap space. The op is saying disabling swap doesn’t prevent long pauses during memory pressure, because the system just swaps code out instead of dynamically allocated memory.
      • silon42 24 minutes ago
        It would probably make sense to disable swapping "code" also for non-GC languages (or at least do it as a last resort).
      • quotemstr 1 hour ago
        Plus, it wouldn't necessarily be that hard to selectively mlock the pages accessed in STW critical regions.
  • xavdid 1 hour ago
    Discord learned this back in 2020 and published a great blog post on it: https://discord.com/blog/why-discord-is-switching-from-go-to...
    • iamvik 30 minutes ago
      I don't understand why they felt necessary to rewrite a core component in another language. If you have a garbage collection problem my first intuition would be to produce less garbage!

      For example better using the stack, or pulling out the big gun of manual memory management.

      I'm sure they had reasons to choose Go when they first designed this project but they don't go into them at all.

      Feels like they just wanted to play with a new toy.

      • Someone 20 minutes ago
        > If you have a garbage collection problem my first intuition would be to produce less garbage!

        FTA:

        “These latency spikes definitely smelled like garbage collection performance impact, but we had written the Go code very efficiently and had very few allocations. We were not creating a lot of garbage.

        […]

        the spikes were huge not because of a massive amount of ready-to-free memory, but because the garbage collector needed to scan the entire LRU cache in order to determine if the memory was truly free from references”

      • uqers 21 minutes ago
        > produce less garbage!

        They explained in the post why this wasn't an issue: they were producing very little garbage, but there was a very large object graph.

        > manual memory management

        If you need to do manual memory management in a GC language with no builtin support for it, like Go, that's probably a sign that you should switch to a different language.

        • pjmlp 8 minutes ago
          Like D, a proper systems language with GC, and builtin support for manual memory management, and there are others as well.
      • virtualSatai 23 minutes ago
        If you read the link you'll see that they found out go forces a GC every two minutes no matter the amount of garbage.
    • maccard 51 minutes ago
      That’s a great read. And an incredibly annoying “floating footer”
      • MYEUHD 47 minutes ago
        If you're on desktop, you can use uBlock origin's element zapper to remove annoying things like that.
  • pizlonator 3 hours ago
    Is there a reason why Go isn’t using on the fly GC, where there’s no STW at all?
    • klodolph 3 hours ago
      What I found when I searched for "on the fly" is this: https://github.com/mthom/on-the-fly-gc — it looks like it has pauses, from the docs.

      In general when you tune knobs for GC, you pay for benefits in one area with sacrifices in another. Two big knobs to turn are pause latency and throughput. You probably wouldn’t want to go full “optimize for latency” because you’d end up with poor throughput. Also vice versa. Java’s reputation for poor GC performance is partly due to historical defaults that tune it for throughput.

      Go’s GC is already a “concurrent mark-sweep garbage collector” and already has “extremely low mutator pause times, on the order of tens of microseconds”. It sounds like on-the-fly is just a different flavor of what Go already has.

      • pizlonator 3 hours ago
        The classic on the fly GC algorithm is DLG, hilariously published in two papers, because the first one had a bug. Here's the second paper: https://caml.inria.fr/pub/papers/doligez_gonthier-gc-popl94....

        It's a well known algorithm. Folks who do GCs for a living know about it. The folks who work on Go are surely aware of it. I'm assuming that they do not use it for a good reason, hence my question!

        Fil-C's GC (Fil's Unbelievable Garbage Collector) uses an alternative on-the-fly algorithm, which I call Phil's Concurrent Marking.

        I've documented it here: https://fil-c.org/fugc

        Here's the source: https://github.com/pizlonator/fil-c/blob/deluge/libpas/src/l...

        Phil's Concurrent Marking differs from DLG in that it only requires a Djikstra barrier and uses a permagrey stack (something that Go used to do).

        However, FUGC does clever things for coroutines (as in ucontexts, which Fil-C supports) - they are not permagrey; they only become grey if they execute. That's relevant to Go because Go moved away from permagrey stacks because of coroutine scan overheads, which the FUGC coroutine strategy might avoid.

        But even if Go could not go back to permagrey, then the answer would be to use DLG, which would involve using the combined Yuasa+Dijstra barrier, which Go uses today anyway

  • imclaren 1 hour ago
    This. Memory bloat bugs are relatively easy to fix in Go, but sometimes it’s an adventure to remove swap bloat. And I think it’s worth removing all swap bloat!
  • Gabrys1 1 hour ago
    I started wondering if there could be swap-aware GC, like first make the required page swapped in (not that there's any obvious API for that...) and only then pause the world?
    • debugnik 1 hour ago
      Aren't madvise and mincore the APIs you want?
    • serbuvlad 1 hour ago
      One can just add APIs to the Linux kernel, and this would be a pretty straightforward one. (though it might be a little more difficult to avoid a syscall here)

      I'm sure an agent can work on this and get some numbers with a day's worth of tokens.

      • loeg 56 minutes ago
        The API already exists: mlock.
        • keybored 32 minutes ago
          I think we are not realizing the paradigm shift here. A coding agent can implement this with a modest little day’s worth of tokens. This means that no one needs to read or know the APIs any more. We can just add them to the kernel as we need them. Then when we forget that we needed them we can just rediscover the API idea later and spend a day’s worth of tokens. (But let’s be real here. By then it will probably be just 1/3 worth of tokens with all the model improvements as well as the ample training material.)
      • jstarks 1 hour ago
        You don’t need an api. Just touch the page.
    • quotemstr 1 hour ago
      You could do lots of interesting things with sufficiently deep inter-layer integration.

      For example, why not swap out not by LRU page but by dense node clusters on the heap graph, maintaining in-memory summaries of inbound and outbound edges for liveness? If you do this, you don't have to swap the cluster in to do a GC involving it.

      If the whole cluster becomes unreachable, you wouldn't even have to swap it back in to get rid of it: you'd just drop the swap reference and deem the swap space free.

      I don't see anything this deeply integrated happening near-term, but it's fun to think about.

  • soltanov 3 hours ago
    A GC latency SLO should include operating-system memory pressure. Otherwise, a page-fault problem will look like a collector problem and lead to the wrong fix.
    • MobiusHorizons 21 minutes ago
      Can’t page faults be arbitrarily long though? How could you provide a meaningful SLO in that case?
  • faangguyindia 1 hour ago
    I use Go where i'd use Node, Ruby or Python.

    I use Rust where i need low latency.

  • ahmedmostafa16 2 hours ago
    The nasty bit is that swap doesn't just make the allocation slower; if GC metadata gets paged out, you have turned memory pressure into a stop-the-world latency spike.
  • raverbashing 2 hours ago
    I don't get why people do not prefer reference counting, it has more predictable runtime performance

    (though of course a swap is a swap - but you can "trigger" it depending on your memory or file access pattern)

    • pjmlp 4 minutes ago
      Because the industry has plenty of experience with referece counting as the very first GC algorithm, already in the early 1960's, in early Lisp implementations, BASIC, Cedar, and several other languages.

      The predictable runtime performance is also a myth, because they never take into account the use of NUMA memory, lock contention, possible stack overflow and stop the world in the case of cascaded deletions in naive implementations.

    • xxs 1 hour ago
      ref counting is expensive in multi-threaded applications. Overall it would have worse performance. When it comes to predictability: deallocating a linked list (for instance) would have to deallocate all of the elements. Dealing with reference cycles is also not simple, either.
    • groestl 1 hour ago
      Overhead per allocation, if you care about that, and reference circles.
    • bheadmaster 1 hour ago
      > more predictable runtime performance

      Not really, reference counting can cause a single object deallocation to trigger an arbitrarily long chain of deallocations.

  • loeg 57 minutes ago
    So, uh, mlock those pages?
  • octoberfranklin 3 hours ago
    Yet another reason why "no runtime" is such a huge advantage.
    • my-next-account 2 hours ago
      You're probably coding for a 'runtime' in the broad sense: libc and your kernel.
      • MathMonkeyMan 1 hour ago
        Microcontroller! The platform is the peripherals.
  • lin7c 1 hour ago
    [flagged]
  • truth_seeker 3 hours ago
    What is stopping the author to use latest version of Go and Linux Kernel ?